Axel
|
I made a lot of changes to an Artisteer theme and would like to get to the bottom of it to get it al right, but there are a few questions I find no answer to.
01. THEME_NS
On top in functions.php there is define('THEME_NS', 'twentyten');.
--- What is it for?
I changed a lot of content with THEME_NS in the end.
--- Should I change this when I add new language files?
In library/widgets.php there is a variable in it:
echo '<option' . $selected . ' value='' . $s . ''>' . __($s, THEME_NS) . '</option>';
--- Would it make sense to just add $s instead?
02. EOL
When testing the file with Theme Checker, I get the following and similar errors:
Quote :WARNING: Both DOS and UNIX style line endings were found in the file library/wrappers.php. This causes a problem with SVN repositories and must be corrected before the theme can be accepted. Please change the file to use only one style of line endings.
I notice this is on all php files with <<<EOL (something to include) EOL;
Looking it up I read it is bad practice to combine DOS & UNIX end of lines, but I only find info on \n \r, not on <<<EOL.
In library/defaults.php this solved replacing it with '(something to include)'; (+ adding \ before '), but this does not work in functions.php. I did not try the others yet.
--- What should I add to replace EOLs?
Thank you already for your help!
|